-
Notifications
You must be signed in to change notification settings - Fork 172
Background search in Discover and Dashboards #3455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background search in Discover and Dashboards #3455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor pieces of feedback, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx, nothing to add to the comments @lukasolson added 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few editing suggestions.
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
This PR edits the search sessions/background search settings page. **Must merge the following PR first to re-add a link to a new page here:** Relates to: elastic/docs-content#3455
This PR edits the search sessions/background search settings page. **Must merge the following PR first to re-add a link to a new page here:** Relates to: elastic/docs-content#3455 (cherry picked from commit 03a57fb)
This PR edits the search sessions/background search settings page. **Must merge the following PR first to re-add a link to a new page here:** Relates to: elastic/docs-content#3455
This PR edits the search sessions/background search settings page. **Must merge the following PR first to re-add a link to a new page here:** Relates to: elastic/docs-content#3455
This PR edits the search sessions/background search settings page. **Must merge the following PR first to re-add a link to a new page here:** Relates to: elastic/docs-content#3455
This PR: - Repurposes the Search sessions page into Background search. The feature being essentially the same on the UX side (a few changes still), and using the same settings behind the scenes, we chose to update the existing page rather than create a new one. - Calls out that search sessions, which is a deprecated feature since 8.15 and disabled by default, are being replaced with this new background search feature, so that search sessions users know what's happening. - Adds references to background search to a few places to increase its visibility. - Discover overview docs on searching & filtering - Glossary - Dashboards docs as a tip for slow loading scenarios - Removes the old search sessions example in favor of more generic but goal-oriented small sections The update to the Search session settings page are in elastic/kibana#238699 as these source files are in another repo Closes: elastic#3105 --------- Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
This PR: - Repurposes the Search sessions page into Background search. The feature being essentially the same on the UX side (a few changes still), and using the same settings behind the scenes, we chose to update the existing page rather than create a new one. - Calls out that search sessions, which is a deprecated feature since 8.15 and disabled by default, are being replaced with this new background search feature, so that search sessions users know what's happening. - Adds references to background search to a few places to increase its visibility. - Discover overview docs on searching & filtering - Glossary - Dashboards docs as a tip for slow loading scenarios - Removes the old search sessions example in favor of more generic but goal-oriented small sections The update to the Search session settings page are in elastic/kibana#238699 as these source files are in another repo Closes: elastic#3105 --------- Co-authored-by: Arianna Laudazzi <46651782+alaudazzi@users.noreply.github.com>
This PR:
The update to the Search session settings page are in elastic/kibana#238699 as these source files are in another repo
Closes: #3105